Skip to content

create and update product functionality added #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

sauravces
Copy link
Owner

create and update product functionality added .

Copy link

@kool7 kool7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove bin and obj folder so that PR can be reviewed.

@kool7
Copy link

kool7 commented Jun 7, 2024

Please remove bin and obj folder so that PR can be reviewed.

You may have to create a new PR.

Copy link

@tushar-69 tushar-69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin & Obj folders are not required to be checked in.

private readonly IProductService _productService;
private readonly IMapper _mapper;

public ProductController(IProductService productService,IMapper mapper)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use primary constructor ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can ,but for dependency injection parameterized constructor is good choice .

@sauravces sauravces closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants