Skip to content

Commit 1565b9c

Browse files
committed
Rename includedUrls to loadedUrls
This is more explicit, and matches the name in the embedded protocol.
1 parent 558ca0a commit 1565b9c

File tree

5 files changed

+23
-23
lines changed

5 files changed

+23
-23
lines changed

lib/src/compile_result.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class CompileResult {
2727
SingleMapping? get sourceMap => _serialize.sourceMap;
2828

2929
/// The canonical URLs of all stylesheets loaded during compilation.
30-
Set<Uri> get includedUrls => _evaluate.includedUrls;
30+
Set<Uri> get loadedUrls => _evaluate.loadedUrls;
3131

3232
/// @nodoc
3333
@internal

lib/src/node.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ RenderResult _newRenderResult(
410410
end: end.millisecondsSinceEpoch,
411411
duration: end.difference(start).inMilliseconds,
412412
includedFiles: [
413-
for (var url in result.includedUrls)
413+
for (var url in result.loadedUrls)
414414
if (url.scheme == 'file') p.fromUri(url) else url.toString()
415415
]));
416416
}

lib/src/visitor/async_evaluate.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ class _EvaluateVisitor
217217
var _inKeyframes = false;
218218

219219
/// The canonical URLs of all stylesheets loaded during compilation.
220-
final _includedUrls = <Uri>{};
220+
final _loadedUrls = <Uri>{};
221221

222222
/// A map from canonical URLs for modules (or imported files) that are
223223
/// currently being evaluated to AST nodes whose spans indicate the original
@@ -504,12 +504,12 @@ class _EvaluateVisitor
504504
var url = node.span.sourceUrl;
505505
if (url != null) {
506506
_activeModules[url] = null;
507-
if (!(_asNodeSass && url.toString() == 'stdin')) _includedUrls.add(url);
507+
if (!(_asNodeSass && url.toString() == 'stdin')) _loadedUrls.add(url);
508508
}
509509

510510
var module = await _execute(importer, node);
511511

512-
return EvaluateResult(_combineCss(module), _includedUrls);
512+
return EvaluateResult(_combineCss(module), _loadedUrls);
513513
});
514514
}
515515

@@ -1567,15 +1567,15 @@ class _EvaluateVisitor
15671567
tuple.item1, tuple.item2,
15681568
originalUrl: tuple.item3, quiet: _quietDeps && isDependency);
15691569
if (stylesheet != null) {
1570-
_includedUrls.add(tuple.item2);
1570+
_loadedUrls.add(tuple.item2);
15711571
return _LoadedStylesheet(stylesheet,
15721572
importer: tuple.item1, isDependency: isDependency);
15731573
}
15741574
}
15751575
} else {
15761576
var result = await _importLikeNode(url, forImport);
15771577
if (result != null) {
1578-
result.stylesheet.span.sourceUrl.andThen(_includedUrls.add);
1578+
result.stylesheet.span.sourceUrl.andThen(_loadedUrls.add);
15791579
return result;
15801580
}
15811581
}
@@ -3309,9 +3309,9 @@ class EvaluateResult {
33093309
final CssStylesheet stylesheet;
33103310

33113311
/// The canonical URLs of all stylesheets loaded during compilation.
3312-
final Set<Uri> includedUrls;
3312+
final Set<Uri> loadedUrls;
33133313

3314-
EvaluateResult(this.stylesheet, this.includedUrls);
3314+
EvaluateResult(this.stylesheet, this.loadedUrls);
33153315
}
33163316

33173317
/// The result of evaluating arguments to a function or mixin.

lib/src/visitor/evaluate.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ class _EvaluateVisitor
225225
var _inKeyframes = false;
226226

227227
/// The canonical URLs of all stylesheets loaded during compilation.
228-
final _includedUrls = <Uri>{};
228+
final _loadedUrls = <Uri>{};
229229

230230
/// A map from canonical URLs for modules (or imported files) that are
231231
/// currently being evaluated to AST nodes whose spans indicate the original
@@ -509,12 +509,12 @@ class _EvaluateVisitor
509509
var url = node.span.sourceUrl;
510510
if (url != null) {
511511
_activeModules[url] = null;
512-
if (!(_asNodeSass && url.toString() == 'stdin')) _includedUrls.add(url);
512+
if (!(_asNodeSass && url.toString() == 'stdin')) _loadedUrls.add(url);
513513
}
514514

515515
var module = _execute(importer, node);
516516

517-
return EvaluateResult(_combineCss(module), _includedUrls);
517+
return EvaluateResult(_combineCss(module), _loadedUrls);
518518
});
519519
}
520520

@@ -1565,15 +1565,15 @@ class _EvaluateVisitor
15651565
var stylesheet = importCache.importCanonical(tuple.item1, tuple.item2,
15661566
originalUrl: tuple.item3, quiet: _quietDeps && isDependency);
15671567
if (stylesheet != null) {
1568-
_includedUrls.add(tuple.item2);
1568+
_loadedUrls.add(tuple.item2);
15691569
return _LoadedStylesheet(stylesheet,
15701570
importer: tuple.item1, isDependency: isDependency);
15711571
}
15721572
}
15731573
} else {
15741574
var result = _importLikeNode(url, forImport);
15751575
if (result != null) {
1576-
result.stylesheet.span.sourceUrl.andThen(_includedUrls.add);
1576+
result.stylesheet.span.sourceUrl.andThen(_loadedUrls.add);
15771577
return result;
15781578
}
15791579
}

test/dart_api_test.dart

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -226,46 +226,46 @@ a {
226226
});
227227
});
228228

229-
group("includedUrls", () {
229+
group("loadedUrls", () {
230230
group("contains the entrypoint's URL", () {
231231
group("in compileStringToResult()", () {
232232
test("if it's given", () {
233233
var result = compileStringToResult("a {b: c}", url: "source.scss");
234-
expect(result.includedUrls, equals([Uri.parse("source.scss")]));
234+
expect(result.loadedUrls, equals([Uri.parse("source.scss")]));
235235
});
236236

237237
test("unless it's not given", () {
238238
var result = compileStringToResult("a {b: c}");
239-
expect(result.includedUrls, isEmpty);
239+
expect(result.loadedUrls, isEmpty);
240240
});
241241
});
242242

243243
test("in compileToResult()", () async {
244244
await d.file("input.scss", "a {b: c};").create();
245245
var result = compileToResult(d.path('input.scss'));
246-
expect(result.includedUrls, equals([p.toUri(d.path('input.scss'))]));
246+
expect(result.loadedUrls, equals([p.toUri(d.path('input.scss'))]));
247247
});
248248
});
249249

250250
test("contains a URL loaded via @import", () async {
251251
await d.file("_other.scss", "a {b: c}").create();
252252
await d.file("input.scss", "@import 'other';").create();
253253
var result = compileToResult(d.path('input.scss'));
254-
expect(result.includedUrls, contains(p.toUri(d.path('_other.scss'))));
254+
expect(result.loadedUrls, contains(p.toUri(d.path('_other.scss'))));
255255
});
256256

257257
test("contains a URL loaded via @use", () async {
258258
await d.file("_other.scss", "a {b: c}").create();
259259
await d.file("input.scss", "@use 'other';").create();
260260
var result = compileToResult(d.path('input.scss'));
261-
expect(result.includedUrls, contains(p.toUri(d.path('_other.scss'))));
261+
expect(result.loadedUrls, contains(p.toUri(d.path('_other.scss'))));
262262
});
263263

264264
test("contains a URL loaded via @forward", () async {
265265
await d.file("_other.scss", "a {b: c}").create();
266266
await d.file("input.scss", "@forward 'other';").create();
267267
var result = compileToResult(d.path('input.scss'));
268-
expect(result.includedUrls, contains(p.toUri(d.path('_other.scss'))));
268+
expect(result.loadedUrls, contains(p.toUri(d.path('_other.scss'))));
269269
});
270270

271271
test("contains a URL loaded via @meta.load-css()", () async {
@@ -275,7 +275,7 @@ a {
275275
@include meta.load-css('other');
276276
""").create();
277277
var result = compileToResult(d.path('input.scss'));
278-
expect(result.includedUrls, contains(p.toUri(d.path('_other.scss'))));
278+
expect(result.loadedUrls, contains(p.toUri(d.path('_other.scss'))));
279279
});
280280

281281
test("contains a URL loaded via a chain of loads", () async {
@@ -289,7 +289,7 @@ a {
289289
""").create();
290290
var result = compileToResult(d.path('mercury.scss'));
291291
expect(
292-
result.includedUrls,
292+
result.loadedUrls,
293293
unorderedEquals([
294294
p.toUri(d.path('mercury.scss')),
295295
p.toUri(d.path('_venus.scss')),

0 commit comments

Comments
 (0)