fix lint issues (#29)

* fix lint issues

* add changelog fragment

* fix description

* change action checkout version

* missing action v3

Author: rainerleber

.github/workflows/ansible-test.yml

@@ -32,7 +32,7 @@ jobs:
     steps:
 
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Perform sanity testing with ansible-test
         uses: ansible-community/ansible-test-gh-action@release/v1
@@ -62,7 +62,7 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Perform unit testing with ansible-test
         uses: ansible-community/ansible-test-gh-action@release/v1
@@ -105,7 +105,7 @@ jobs:
 
   #   steps:
   #     - name: Check out code
-  #       uses: actions/checkout@v2
+  #       uses: actions/checkout@v3
 
   #     - name: Perform integration testing with ansible-test
   #       uses: ansible-community/ansible-test-gh-action@release/v1

changelogs/fragments/29-fix-lint-issues.yml

@@ -0,0 +1,6 @@
+bugfixes:
+  - fixes failures in sanity test for plugins/modules/sap_pyrfc.py
+  - fixes failures in sanity test for tests/unit/compat/builtins.py
+  - fixes failures in sanity test for tests/unit/plugins/modules/test_sap_system_facts.py
+  - fixes failures in sanity test for tests/unit/plugins/modules/test_sap_system_facts.py
+  - fixes pipeline warnings

plugins/modules/sap_pyrfc.py

@@ -113,7 +113,7 @@
 from ..module_utils.pyrfc_handler import get_connection
 
 try:
-    from pyrfc import ABAPApplicationError, ABAPRuntimeError, CommunicationError, Connection, LogonError
+    from pyrfc import ABAPApplicationError, ABAPRuntimeError, CommunicationError, LogonError
 except ImportError:
     HAS_PYRFC_LIBRARY = False
     PYRFC_LIBRARY_IMPORT_ERROR = traceback.format_exc()

tests/unit/compat/builtins.py

@@ -22,12 +22,3 @@
 #
 # Compat for python2.7
 #
-
-# One unittest needs to import builtins via __import__() so we need to have
-# the string that represents it
-try:
-    import __builtin__
-except ImportError:
-    BUILTINS = 'builtins'
-else:
-    BUILTINS = '__builtin__'

tests/unit/plugins/modules/test_sap_system_facts.py

@@ -5,12 +5,11 @@
 
 from __future__ import absolute_import, division, print_function
 
-import mock
 __metaclass__ = type
 
 from ansible_collections.community.sap_libs.plugins.modules import sap_system_facts
 from ansible_collections.community.sap_libs.tests.unit.plugins.modules.utils import AnsibleExitJson, ModuleTestCase
-from ansible_collections.community.sap_libs.tests.unit.compat.mock import patch, MagicMock
+from ansible_collections.community.sap_libs.tests.unit.compat.mock import patch
 from ansible.module_utils import basic