[ORG] RU-AXAV: Removes the purge thread in favor of standard ScheduledThreadPoolExec… #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utor APIs (#7293) The RXSchedulerPurge thread is currently enabled by default and runs every second to call purge() on each executor in the pool. This is causing significant issues for low powered devices (e.g. mobile phones), because it needs to periodically wake up the CPU to perform purging. The RXSchedulerPurge thread could be completely removed in favor of using the standard setRemoveOnCancelPolicy() API on the ScheduledThreadPoolExecutor which became available in Java 7 and offers removal of cancelled tasks at the moment they are cancelled in O(1).
Codecov Report
@@ Coverage Diff @@
## 3.x #30 +/- ##
============================================
+ Coverage 99.51% 99.56% +0.04%
+ Complexity 6757 6744 -13
============================================
Files 747 747
Lines 47391 47347 -44
Branches 6382 6376 -6
============================================
- Hits 47161 47139 -22
+ Misses 105 92 -13
+ Partials 125 116 -9
Continue to review full report at Codecov.
|
sakibguy
changed the title
sakibguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utor APIs (ReactiveX#7293)
The RXSchedulerPurge thread is currently enabled by default and runs every second
to call purge() on each executor in the pool. This is causing significant issues
for low powered devices (e.g. mobile phones), because it needs to periodically
wake up the CPU to perform purging. The RXSchedulerPurge thread could be completely
removed in favor of using the standard setRemoveOnCancelPolicy() API on the
ScheduledThreadPoolExecutor which became available in Java 7 and offers removal
of cancelled tasks at the moment they are cancelled in O(1).
Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:
Please give a description about what and why you are contributing, even if it's trivial.
Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.
Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an
empty,just,rangeof values as well as anerrorsource, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.