Skip to content

[ORG] RU-MAKEAPP: 3.x: Update withLatestFrom doc about upstream early complete (#7289) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

sakibguy
Copy link
Owner

@sakibguy sakibguy commented Jul 5, 2021

  • 3.x: Update withLatestFrom doc about upstream early complete

  • Fix singular wording

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

  • Please give a description about what and why you are contributing, even if it's trivial.

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

* 3.x: Update withLatestFrom doc about upstream early complete

* Fix singular wording
@sakibguy sakibguy added the bug Something isn't working label Jul 5, 2021
@sakibguy sakibguy self-assigned this Jul 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #28 (4749ab3) into 3.x (91a10d4) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x      #28      +/-   ##
============================================
+ Coverage     99.51%   99.52%   +0.01%     
+ Complexity     6757     6754       -3     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
+ Hits          47161    47166       +5     
+ Misses          105      100       -5     
  Partials        125      125              
Impacted Files Coverage Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-3.18%) ⬇️
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) ⬇️
...o/reactivex/rxjava3/processors/AsyncProcessor.java 97.91% <0.00%> (-2.09%) ⬇️
...reactivex/rxjava3/processors/PublishProcessor.java 98.16% <0.00%> (-1.84%) ⬇️
...nternal/operators/observable/ObservableWindow.java 98.21% <0.00%> (-1.79%) ⬇️
...nternal/operators/parallel/ParallelSortedJoin.java 98.49% <0.00%> (-1.51%) ⬇️
...ators/observable/ObservableFlatMapCompletable.java 98.52% <0.00%> (-1.48%) ⬇️
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a10d4...4749ab3. Read the comment docs.

@sakibguy sakibguy merged commit 79d5e36 into sakibguy:3.x Jul 6, 2021
Copy link
Owner Author

@sakibguy sakibguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@sakibguy sakibguy changed the title 3.x: Update withLatestFrom doc about upstream early complete (#7289) RU-MAKEAPP: 3.x: Update withLatestFrom doc about upstream early complete (#7289) Jan 27, 2023
@sakibguy sakibguy changed the title RU-MAKEAPP: 3.x: Update withLatestFrom doc about upstream early complete (#7289) [ORG] RU-MAKEAPP: 3.x: Update withLatestFrom doc about upstream early complete (#7289) Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants