Skip to content

Commit 32f121b

Browse files
author
Release Manager
committed
gh-39275: Specify use_sources=True in cython compilation In my testing, this allows cython compilation of code with `from sage.[...] cimport [...]` to work when built with meson. Ability to compile cython code when use legacy build system is unaffected. Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39275 Reported by: user202729 Reviewer(s): Tobias Diez
2 parents b214aae + 6478f43 commit 32f121b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/sage/misc/cython.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def _standard_libs_libdirs_incdirs_aliases():
6060
if SAGE_LOCAL:
6161
standard_libdirs.append(os.path.join(SAGE_LOCAL, "lib"))
6262
standard_libdirs.extend(aliases["CBLAS_LIBDIR"] + aliases["NTL_LIBDIR"])
63-
standard_incdirs = sage_include_directories() + aliases["CBLAS_INCDIR"] + aliases["NTL_INCDIR"]
63+
standard_incdirs = sage_include_directories(use_sources=True) + aliases["CBLAS_INCDIR"] + aliases["NTL_INCDIR"]
6464
return standard_libs, standard_libdirs, standard_incdirs, aliases
6565

6666
################################################################

0 commit comments

Comments
 (0)