Skip to content

Commit 1b436ab

Browse files
author
Release Manager
committed
gh-38199: Delete _check_rank_two method for Drinfeld modules This method does nothing if the Drinfeld module has rank two, and raises an exception otherwise. It was introduced in the first version of the implementation, when some methods were only available for the rank two case (e.g. `frobenius_trace`, `frobenius_norm`, etc). A `grep` reveals that the method is never called, which makes it useless. Therefore, I propose to remove it. URL: #38199 Reported by: Antoine Leudière Reviewer(s): David Ayotte
2 parents 2fa55f3 + 7de3be5 commit 1b436ab

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -759,27 +759,6 @@ def _Hom_(self, other, category):
759759
from sage.rings.function_field.drinfeld_modules.homset import DrinfeldModuleHomset
760760
return DrinfeldModuleHomset(self, other, category)
761761

762-
def _check_rank_two(self):
763-
r"""
764-
Raise ``NotImplementedError`` if the rank is not two.
765-
766-
TESTS::
767-
768-
sage: Fq = GF(25)
769-
sage: A.<T> = Fq[]
770-
sage: K.<z12> = Fq.extension(6)
771-
sage: p_root = 2*z12^11 + 2*z12^10 + z12^9 + 3*z12^8 + z12^7 + 2*z12^5 + 2*z12^4 + 3*z12^3 + z12^2 + 2*z12
772-
sage: phi = DrinfeldModule(A, [p_root, z12^3, z12^5])
773-
sage: phi._check_rank_two()
774-
sage: phi = DrinfeldModule(A, [p_root, 1])
775-
sage: phi._check_rank_two()
776-
Traceback (most recent call last):
777-
...
778-
NotImplementedError: rank must be 2
779-
"""
780-
if self.rank() != 2:
781-
raise NotImplementedError('rank must be 2')
782-
783762
def _latex_(self):
784763
r"""
785764
Return a LaTeX representation of the Drinfeld module.

0 commit comments

Comments
 (0)