Skip to content

Commit e5a3816

Browse files
committed
Revert unneeded changes/PR feedback
1 parent ca51e57 commit e5a3816

File tree

3 files changed

+11
-18
lines changed

3 files changed

+11
-18
lines changed

src/Compiler/Service/IncrementalBuild.fs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,8 +1368,7 @@ type IncrementalBuilder(initialState: IncrementalBuilderInitialState, state: Inc
13681368
| (ilAssemRef, tcAssemblyDataOpt, tcAssemblyExprOpt, boundModel), timestamp ->
13691369
let cache = TimeStampCache defaultTimeStamp
13701370
let projectTimeStamp = builder.GetLogicalTimeStampForProject(cache)
1371-
let res = PartialCheckResults (boundModel, timestamp, projectTimeStamp), ilAssemRef, tcAssemblyDataOpt, tcAssemblyExprOpt
1372-
return res
1371+
return PartialCheckResults (boundModel, timestamp, projectTimeStamp), ilAssemRef, tcAssemblyDataOpt, tcAssemblyExprOpt
13731372
}
13741373

13751374
member builder.GetFullCheckResultsAndImplementationsForProject() =

src/Compiler/Service/service.fs

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,19 +1527,16 @@ type FSharpChecker
15271527
options: FSharpProjectOptions,
15281528
?userOpName: string
15291529
) =
1530-
async {
1531-
let userOpName = defaultArg userOpName "Unknown"
1532-
return!
1533-
backgroundCompiler.CheckFileInProjectAllowingStaleCachedResults(
1534-
parseResults,
1535-
fileName,
1536-
fileVersion,
1537-
SourceText.ofString source,
1538-
options,
1539-
userOpName
1540-
)
1541-
|> Async.AwaitNodeCode
1542-
}
1530+
let userOpName = defaultArg userOpName "Unknown"
1531+
backgroundCompiler.CheckFileInProjectAllowingStaleCachedResults(
1532+
parseResults,
1533+
fileName,
1534+
fileVersion,
1535+
SourceText.ofString source,
1536+
options,
1537+
userOpName
1538+
)
1539+
|> Async.AwaitNodeCode
15431540

15441541
/// Typecheck a source code file, returning a handle to the results of the
15451542
/// parse including the reconstructed types in the file.

src/fsc/fsc.targets

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@
5151
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" />
5252
<PackageReference Include="System.Runtime.Loader" Version="$(SystemRuntimeLoaderVersion)" />
5353
<PackageReference Include="System.Security.Principal" Version="$(SystemSecurityPrincipalVersion)" />
54-
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.1.0" />
55-
<PackageReference Include="OpenTelemetry.Exporter.Zipkin" Version="1.1.0" />
56-
5754
</ItemGroup>
5855

5956
</Project>

0 commit comments

Comments
 (0)