Use TypeScript to verify CLI reference output #4311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, I changed it to only check JS syntax for now. Fixing all the type errors in JS will require some more work, but that can be a follow-up PR. For now, this PR just checks the types of |
daxpedda
reviewed
Dec 6, 2024
daxpedda
approved these changes
Dec 7, 2024
|
This is great btw, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CI test that uses the TypeScript compiler to verify that all JS and TS files in
cli/tests/referencesare valid JS/TS. This ensures that invalid JS/TS will be caught even if human review misses some error.Since I use the TS compiler to verify JS files, I also enabled type checking for them. So we will hopefully catch invalid glue code early now.
I'm still working out the kinks.