Skip to content

Commit 8eb5300

Browse files
committed
fix: Resolve all clippy warnings in dev-tools crate
- Fixed unused variable warnings by prefixing with underscore - Removed dead code with allow attribute for test function - Fixed field assignment patterns using struct literals - Added allow attributes for recursive functions with self parameter - Cleaned up let-and-return pattern All clippy warnings are now resolved while maintaining functionality.
1 parent 8c54a8a commit 8eb5300

File tree

5 files changed

+41
-35
lines changed

5 files changed

+41
-35
lines changed

crates/codeprism-dev-tools/src/ast_visualizer.rs

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ impl AstVisualizer {
239239
}
240240

241241
/// Visualize in list format
242-
fn visualize_list_format(&self, node: &Node, source: &str) -> Result<String> {
242+
fn visualize_list_format(&self, node: &Node, _source: &str) -> Result<String> {
243243
let mut output = String::new();
244244
let mut cursor = node.walk();
245245
let mut depth = 0;
@@ -494,6 +494,7 @@ impl AstVisualizer {
494494
}
495495

496496
/// Recursively collect AST statistics
497+
#[allow(clippy::only_used_in_recursion)]
497498
fn collect_statistics(&self, node: &Node, stats: &mut AstStatistics, depth: usize) {
498499
stats.total_nodes += 1;
499500
stats.max_depth = stats.max_depth.max(depth);
@@ -521,7 +522,7 @@ impl AstVisualizer {
521522
}
522523

523524
/// Compare two ASTs and highlight differences
524-
pub fn compare_asts(&self, old_node: &Node, new_node: &Node, source: &str) -> Result<String> {
525+
pub fn compare_asts(&self, old_node: &Node, new_node: &Node, _source: &str) -> Result<String> {
525526
let mut output = String::new();
526527
output.push_str("=== AST Comparison ===\n\n");
527528

@@ -614,6 +615,7 @@ mod tests {
614615
use super::*;
615616
use tree_sitter::Parser;
616617

618+
#[allow(dead_code)]
617619
fn create_test_parser() -> Parser {
618620
// For testing, we'll use a simple language grammar
619621
// In real usage, this would use the appropriate language
@@ -629,9 +631,11 @@ mod tests {
629631

630632
#[test]
631633
fn test_custom_config() {
632-
let mut config = VisualizationConfig::default();
633-
config.max_depth = 10;
634-
config.show_positions = false;
634+
let config = VisualizationConfig {
635+
max_depth: 10,
636+
show_positions: false,
637+
..Default::default()
638+
};
635639

636640
let visualizer = AstVisualizer::with_config(config);
637641
assert_eq!(visualizer.config.max_depth, 10);
@@ -648,8 +652,10 @@ mod tests {
648652

649653
#[test]
650654
fn test_format_node_type_without_colors() {
651-
let mut config = VisualizationConfig::default();
652-
config.use_colors = false;
655+
let config = VisualizationConfig {
656+
use_colors: false,
657+
..Default::default()
658+
};
653659
let visualizer = AstVisualizer::with_config(config);
654660

655661
let formatted = visualizer.format_node_type("function_definition");
@@ -658,11 +664,13 @@ mod tests {
658664

659665
#[test]
660666
fn test_ast_statistics_display() {
661-
let mut stats = AstStatistics::default();
662-
stats.total_nodes = 100;
663-
stats.named_nodes = 80;
664-
stats.unnamed_nodes = 20;
665-
stats.max_depth = 5;
667+
let mut stats = AstStatistics {
668+
total_nodes: 100,
669+
named_nodes: 80,
670+
unnamed_nodes: 20,
671+
max_depth: 5,
672+
..Default::default()
673+
};
666674
stats.node_type_counts.insert("function".to_string(), 10);
667675
stats.node_type_counts.insert("identifier".to_string(), 30);
668676

crates/codeprism-dev-tools/src/diff_comparison.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ impl AstDiff {
124124
&self,
125125
old_result: &ParseResult,
126126
new_result: &ParseResult,
127-
source: &str,
127+
_source: &str,
128128
) -> Result<DiffReport> {
129129
let mut differences = Vec::new();
130130
let mut statistics = DiffStatistics::default();
@@ -392,6 +392,7 @@ impl AstDiff {
392392
}
393393

394394
/// Calculate tree depth
395+
#[allow(clippy::only_used_in_recursion)]
395396
fn calculate_tree_depth(&self, node: &tree_sitter::Node) -> usize {
396397
let mut max_depth = 0;
397398
for i in 0..node.child_count() {
@@ -613,7 +614,7 @@ mod tests {
613614
use codeprism_core::{NodeKind, Span};
614615
use std::path::PathBuf;
615616

616-
fn create_test_node(id: u64, name: &str, kind: NodeKind) -> codeprism_core::Node {
617+
fn create_test_node(_id: u64, name: &str, kind: NodeKind) -> codeprism_core::Node {
617618
let path = PathBuf::from("test.rs");
618619
let span = Span::new(0, 10, 1, 1, 1, 10);
619620
let repo_id = "test_repo";
@@ -648,8 +649,10 @@ mod tests {
648649

649650
#[test]
650651
fn test_node_key_ignoring_ids() {
651-
let mut config = DiffConfig::default();
652-
config.ignore_node_ids = true;
652+
let config = DiffConfig {
653+
ignore_node_ids: true,
654+
..Default::default()
655+
};
653656
let diff = AstDiff::with_config(config);
654657

655658
let node1 = create_test_node(1, "test", NodeKind::Function);

crates/codeprism-dev-tools/src/graphviz_export.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ mod tests {
538538
use codeprism_core::{EdgeKind, Language, NodeKind, Span};
539539
use std::path::PathBuf;
540540

541-
fn create_test_node(id: u64, name: &str, kind: NodeKind) -> Node {
541+
fn create_test_node(_id: u64, name: &str, kind: NodeKind) -> Node {
542542
let path = PathBuf::from("test.rs");
543543
let span = Span::new(0, 10, 1, 1, 1, 10);
544544
let repo_id = "test_repo";

crates/codeprism-dev-tools/src/parser_validator.rs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,17 @@ impl ParserValidator {
121121
pub fn validate_complete(
122122
&self,
123123
parse_result: &ParseResult,
124-
source: &str,
124+
_source: &str,
125125
) -> Result<ValidationReport> {
126126
let start_time = std::time::Instant::now();
127127

128128
let mut errors = Vec::new();
129129
let warnings = Vec::new();
130-
let mut statistics = ValidationStatistics::default();
131-
132-
statistics.total_nodes = parse_result.nodes.len();
133-
statistics.total_edges = parse_result.edges.len();
130+
let mut statistics = ValidationStatistics {
131+
total_nodes: parse_result.nodes.len(),
132+
total_edges: parse_result.edges.len(),
133+
..Default::default()
134+
};
134135

135136
// Basic validation checks (simplified for initial implementation)
136137
if self.config.check_span_overlaps {
@@ -158,7 +159,7 @@ impl ParserValidator {
158159
errors: &mut Vec<ValidationError>,
159160
) -> Result<()> {
160161
for (i, node1) in nodes.iter().enumerate() {
161-
for (j, node2) in nodes.iter().enumerate().skip(i + 1) {
162+
for (_j, node2) in nodes.iter().enumerate().skip(i + 1) {
162163
let start1 = node1.span.start_byte;
163164
let end1 = node1.span.end_byte;
164165
let start2 = node2.span.start_byte;

crates/codeprism-dev-tools/src/performance_profiler.rs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -339,18 +339,12 @@ impl PerformanceProfiler {
339339

340340
/// Analyze performance for bottlenecks and trends
341341
fn analyze_performance(&self) -> PerformanceAnalysis {
342-
let mut analysis = PerformanceAnalysis::default();
343-
344-
// Identify bottlenecks
345-
analysis.bottlenecks = self.identify_bottlenecks();
346-
347-
// Analyze trends
348-
analysis.trends = self.analyze_trends();
349-
350-
// Calculate efficiency score
351-
analysis.efficiency_score = self.calculate_efficiency_score();
352-
353-
analysis
342+
PerformanceAnalysis {
343+
bottlenecks: self.identify_bottlenecks(),
344+
trends: self.analyze_trends(),
345+
efficiency_score: self.calculate_efficiency_score(),
346+
..Default::default()
347+
}
354348
}
355349

356350
/// Identify performance bottlenecks

0 commit comments

Comments
 (0)