Skip to content
This repository was archived by the owner on Oct 30, 2019. It is now read-only.

remove spawn from top-level #47

Closed
wants to merge 3 commits into from
Closed

remove spawn from top-level #47

wants to merge 3 commits into from

Conversation

yoshuawuyts
Copy link
Collaborator

This removes the spawn function from the top-level exports

Instead task::spawn should be used. If this were part of std, spawn
wouldn't be a top-level method, so we should keep it in task instead.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ghost
Copy link

ghost commented Aug 1, 2019

Looks good to me! One thing I would note is that runtime::task::spawn is little verbose. Perhaps that'd look better if runtime::task was imported first and then we spawned tasks with task::spawn?

@stbuehler stbuehler mentioned this pull request Aug 10, 2019
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant