Skip to content
This repository was archived by the owner on Oct 30, 2019. It is now read-only.

migrate to .await syntax #28

Closed

Conversation

marcelbuesing
Copy link
Contributor

Migrate from await! to .await

Description

This migrates the project to the new .await syntax.
Basically the replace-await tool did all the work here.

The only exception is the examples/tcp-proxy.rs seems like it's not possible to remove the feature flag yet in the example:

error[E0658]: `await!(<expr>)` macro syntax is unstable, and will soon be removed in favor of `<expr>.await` syntax.
  --> examples/tcp-proxy.rs:30:13
   |
30 |             try_join!(a, b)?;
   |             ^^^^^^^^^^^^^^^
   |
   = note: for more information, see https://github.com/rust-lang/rust/issues/50547
   = help: add #![feature(await_macro)] to the crate attributes to enable
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Motivation and Context

Ran into the following error in my project that I had migrated to .await syntax, workaround for now is to just add the await_macro feature in my crate again.

error[E0658]: `await!(<expr>)` macro syntax is unstable, and will soon be removed in favor of `<expr>.await` syntax.
 --> proj/examples/get.rs:7:1
  |
7 | #[runtime::main]
  | ^^^^^^^^^^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/50547
  = help: add #![feature(await_macro)] to the crate attributes to enable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    Breaking change for anyone using nightly older than nightly-2019-05-09.

@marcelbuesing
Copy link
Contributor Author

Sorry just noticed this is a duplicate of #26

@yoshuawuyts
Copy link
Collaborator

@marcelbuesing thanks heaps for the PR tho!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants