Skip to content

Rework FileSystem::copy to operate on 1MiB chunks #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

nicholasbishop
Copy link
Member

Fixes #824

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop nicholasbishop force-pushed the bishop-improve-copy branch 2 times, most recently from 70f5be2 to f0e372c Compare July 22, 2023 18:16
This space will be used to test copying of large files.
Also add a new test for the copy function.
@phip1611 phip1611 force-pushed the bishop-improve-copy branch from f0e372c to a6ab883 Compare July 24, 2023 11:34
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this :)

@phip1611 phip1611 merged commit 553fb24 into rust-osdev:main Jul 24, 2023
@nicholasbishop nicholasbishop deleted the bishop-improve-copy branch July 24, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize fs::copy
2 participants