boot: Add freestanding version of open_protocol #1270
Merged
+150
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-free-open-proto
branch
from
f329f78 to
8e60a18
Compare
This comes with its own version of the `ScopedProtocol` struct. This one has no `BootServices` reference and no lifetime param. For test coverage, updated `test_uninstall_protocol_interface` to use `boot::open_protocol` instead of the `BootServices` method. The `BootServices` method still has plenty of coverage in the test runner since `BootServices::open_protocol_exclusive` calls `BootServices::open_protocol`, and the former is called in lots of places.
nicholasbishop
force-pushed
the
bishop-free-open-proto
branch
from
8e60a18 to
60c6b9d
Compare
phip1611
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with its own version of the
ScopedProtocolstruct. This one has noBootServicesreference and no lifetime param.For test coverage, updated
test_uninstall_protocol_interfaceto useboot::open_protocolinstead of theBootServicesmethod. TheBootServicesmethod still has plenty of coverage in the test runner sinceBootServices::open_protocol_exclusivecallsBootServices::open_protocol, and the former is called in lots of places.Checklist