Skip to content

uefi: simplify usage of Mode #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2024
Merged

uefi: simplify usage of Mode #1214

merged 1 commit into from
Jun 23, 2024

Conversation

phip1611
Copy link
Member

Closes #458

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 requested a review from nicholasbishop June 23, 2024 17:33
nicholasbishop
nicholasbishop approved these changes Jun 23, 2024
View reviewed changes
uefi/src/proto/console/gop.rs Outdated
@@ -100,7 +100,7 @@ impl GraphicsOutput {
})
}

/// Returns information about all available graphics modes.
/// Returns an [`ModeIter`].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: an -> a

@phip1611 phip1611 enabled auto-merge June 23, 2024 17:45
@phip1611 phip1611 added this pull request to the merge queue Jun 23, 2024
Merged via the queue into rust-osdev:main with commit 3815a04 Jun 23, 2024
12 checks passed
@phip1611 phip1611 deleted the mode branch June 23, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a method, to get Index on uefi::proto::console::gop::Mode
2 participants
@phip1611 @nicholasbishop