Fix uefi-macros trybuild test #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-update-ui-test
branch
8 times, most recently
from
58cbaa4 to
5333d54
Compare
A difference in behavior between CI and local testing was observed for the entry_bad_return_type test. This is due to the way trybuild sets the `--verbose` flag, which is overwritten if RUSTFLAGS is set (as it always is for our CI jobs). Add code in xtask to ensure that `--verbose` still gets set correctly. Also update entry_bad_return_type.stderr to match the expected current output.
nicholasbishop
force-pushed
the
bishop-update-ui-test
branch
from
5333d54 to
2056a0a
Compare
nicholasbishop
changed the title
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A difference in behavior between CI and local testing was observed for the entry_bad_return_type test. This is due to the way trybuild sets the
--verboseflag, which is overwritten if RUSTFLAGS is set (as it always is for our CI jobs). Add code in xtask to ensure that--verbosestill gets set correctly.Also update entry_bad_return_type.stderr to match the expected current output.
Checklist