Skip to content

Replace cstr16! with a declarative macro #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

nicholasbishop
Copy link
Member

@nicholasbishop nicholasbishop commented Apr 21, 2024

Add a new declarative macro that makes use of the ucs2::ucs2_cstr macro. Drop the proc macro from uefi_macros. For users of the uefi API there should be no change, just a different implementation behind the scenes.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

Instead of importing the `cstr16` proc macro from `uefi_macros`, add a new
declarative macro. This makes use of the new `ucs2::ucs2_cstr` declarative
macro, so bump the minimum version of `ucs2` to 0.3.3.
This is replaced by a new `cstr16` declarative macro in the `uefi` crate.
@phip1611
Copy link
Member

Nice

@phip1611 phip1611 added this pull request to the merge queue Apr 21, 2024
Merged via the queue into rust-osdev:main with commit 5ade028 Apr 21, 2024
12 checks passed
@nicholasbishop nicholasbishop deleted the bishop-rework-cstr16-macro branch April 21, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants