Merge pull request #749 from nicholasbishop/bishop-error-from-status

uefi: Panic if an error is created from Status::SUCCESS

Author: phip1611

CHANGELOG.md

@@ -8,6 +8,7 @@
   available regardless of whether the `global_allocator` feature is enabled. The
   `global_allocator` feature now only controls whether `allocator::Allocator` is
   set as Rust's global allocator.
+- `Error::new` and `Error::from` now panic if the status is `SUCCESS`.
 
 ## uefi-macros - [Unreleased]
 

uefi/src/result/error.rs

@@ -14,7 +14,12 @@ pub struct Error<Data: Debug = ()> {
 
 impl<Data: Debug> Error<Data> {
     /// Create an `Error`.
+    ///
+    /// # Panics
+    ///
+    /// Panics if `status` is [`Status::SUCCESS`].
     pub const fn new(status: Status, data: Data) -> Self {
+        assert!(!matches!(status, Status::SUCCESS));
         Self { status, data }
     }
 
@@ -39,7 +44,7 @@ impl<Data: Debug> Error<Data> {
 
 impl From<Status> for Error<()> {
     fn from(status: Status) -> Self {
-        Self { status, data: () }
+        Error::new(status, ())
     }
 }