-
Notifications
You must be signed in to change notification settings - Fork 19
Update to OpenVR SDK 1.0.7 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
04218fd
Update to OpenVR SDK 1.0.7
Ralith 50e98d5
Build OpenVR client lib from source and statically link
Ralith 374a319
Tweak bindings
Ralith 7e5e8ac
Work around apparently broken cmake build on windows
Ralith 68c5154
Fix linking on windows
Ralith bcb7ea4
Update to OpenVR SDK 1.0.8
Ralith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "openvr"] | ||
path = openvr | ||
url = https://github.com/ValveSoftware/openvr.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,21 @@ | ||
#[cfg(target_os="macos")] | ||
fn main() { | ||
println!("cargo:rustc-link-search={}/openvr/lib/osx32", env!("CARGO_MANIFEST_DIR")); | ||
println!("cargo:rustc-link-search={}/openvr/bin/osx32", env!("CARGO_MANIFEST_DIR")); | ||
} | ||
extern crate cmake; | ||
|
||
#[cfg(target_os="linux")] | ||
fn main() { | ||
println!("cargo:rustc-link-search={}/openvr/lib/linux64", env!("CARGO_MANIFEST_DIR")); | ||
println!("cargo:rustc-link-search={}/openvr/bin/linux64", env!("CARGO_MANIFEST_DIR")); | ||
} | ||
let mut cfg = cmake::Config::new("openvr"); | ||
|
||
#[cfg(target_os="windows")] | ||
fn main() { | ||
println!("cargo:rustc-link-search={}/openvr/lib/win64", env!("CARGO_MANIFEST_DIR")); | ||
println!("cargo:rustc-link-search={}/openvr/bin/win64", env!("CARGO_MANIFEST_DIR")); | ||
// Work around broken cmake build | ||
#[cfg(windows)] | ||
cfg.cxxflag("/DWIN32"); | ||
|
||
let dst = cfg.build(); | ||
println!("cargo:rustc-link-search=native={}/lib", dst.display()); | ||
|
||
#[cfg(all(windows, target_pointer_width = "64"))] | ||
println!("cargo:rustc-link-lib=static=openvr_api64"); | ||
|
||
#[cfg(not(all(windows, target_pointer_width = "64")))] | ||
println!("cargo:rustc-link-lib=static=openvr_api"); | ||
|
||
#[cfg(target_os="linux")] | ||
println!("cargo:rustc-link-lib=stdc++"); | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
20 changes: 0 additions & 20 deletions
20
openvr/bin/osx32/libopenvr_api.dylib.dSYM/Contents/Info.plist
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-2.09 MB
openvr/bin/osx32/libopenvr_api.dylib.dSYM/Contents/Resources/DWARF/libopenvr_api.dylib
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding the libs might cause issues when someone downloads rust-openvr-sys from cargo I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The binaries in the upstream repository are excluded as of 50e98d5 because the changes include building the OpenVR client code from source and statically linking it. This should make redistributing binaries which use this library much easier, as there's no need to patch runpaths or muck about with dynamic library search paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, thats great! Thanks