Use BLAS acceleration in .dot() when possible #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify based on the new restriction (Copy).
For some measure of long, seems like the smallest vectors benefit from using the plain generic dot product (32 elements or smaller).
bluss
added a commit
that referenced
this pull request
Feb 28, 2016
Use BLAS acceleration in .dot() when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use BLAS to compute the dot product when possible (for f32 and f64).
Even though our manual scalar product implementation is pretty good, the BLAS implementation still manages to beat it and finish the 1024 element dot product twice as fast. So this is an improvement even in the simplest kinds of cases. (But we still use the generic dot for vectors shorter than 32 elements, since that is faster).
imp_prelude(implementation's prelude) that simplifies importing the main types that we use everywhere.Privthat can be used to attach private methods that can still be used everywhere in the crate.