Skip to content

Add a scalar trait for specializable scalars #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2016
Merged

Add a scalar trait for specializable scalars #90

merged 2 commits into from
Feb 28, 2016

Conversation

bluss
Copy link
Member

@bluss bluss commented Feb 27, 2016

  • Until rust has specialization, we need Any where we want to dispatch for type specialization.
  • Remove deprecated (already mostly empty) module linalg
  • This reduces the number of types we can matrix multiply (as well as operations dot and mean); in return, we can specialize for f32, f64 and other scalar types that linear algebra libraries support.

bluss added 2 commits February 26, 2016 22:51
@bluss
Minor simplification for &Array + &Array code
be70ed3 
(Don't create a .view() when not needed)
@bluss
Add LinalgScalar trait for matrix multiply
2342ede 
We need a type-specializable trait for efficient ops (that can be
blas-specialized), so we need Any (implies 'static), and we want `Copy`
as well to avoid overhead in creating the result array.
bluss added a commit that referenced this pull request Feb 28, 2016
@bluss
Merge pull request #90 from bluss/mat-mul-trait
2da5bc7 
Add a scalar trait for specializable scalars
@bluss bluss merged commit 2da5bc7 into master Feb 28, 2016
@bluss bluss deleted the mat-mul-trait branch February 28, 2016 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bluss