-
Notifications
You must be signed in to change notification settings - Fork 348
Rework subview methods and other related methods #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dcc605f to
d308796
Compare
d308796 to
646898e
Compare
|
Nice reorganization. |
|
Great. I don't have the release overview at the moment, if we have breaking changes in flight already or not. Is it time to start merging them? I can make point releases before then if we need to. |
I just submitted #540, which describes the changes between 0.12.0 and the current master. We haven't merged any breaking changes yet. |
|
One point of interest about the way I've implemented On a related note, I'm currently in the process of clarifying the invariants that methods on |
Without these methods, users must have ownership of dynamic-dimensional arrays to insert/remove axes, which is unnecessarily restrictive.
646898e to
8835b67
Compare
|
I just rebased the commits off the latest master and updated the |
|
Is this ready to merge? Everything looks good to me. |
|
Sure! |
This PR does the following:
subview_inplacetocollapse_axis(deprecating the old name).subview_muttoindex_axis_mut(deprecating the old name).into_subviewtoindex_axis_move(deprecating the old name).do_subtodo_collapse_axis.subviewtoindex_axis(deprecating the old name).slice_inplacetoslice_collapse(deprecating the old name).insert_axis_inplaceandindex_axis_inplaceforIxDynarrays.remove_axis.These changes make method names more uniform, especially between subviews and slicing, and provide new functionality for
IxDynarrays.Possible alternative names for "collapse" include "narrow" and "restrict".
After a while with
slice_inplacedeprecated, we can remove it, then add aslice_inplacemethod forIxDynarrays that removes axes likeslice_movedoes.What do you think?