-
Notifications
You must be signed in to change notification settings - Fork 322
Order statistics #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LukeMathWalker
wants to merge
98
commits into
rust-ndarray:master
from
LukeMathWalker:order-statistics
Closed
Order statistics #461
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
ee0d54d
Added function signature.
LukeMathWalker 9b775d0
Determine the index of the desired element if the array were to be
LukeMathWalker a4bec9d
Added macro use for slice
LukeMathWalker 470af6c
Barebone implementation of randomized_select with the signature of
LukeMathWalker f2eec96
Added rand as a dependency.
LukeMathWalker 92d3433
Added extern crate rand to lib.rs.
LukeMathWalker 8e25ae0
Basic implementation of randomized_partition first section. Missing
LukeMathWalker fc3e570
Using swap where needed, instead of manually doing the swap using clone.
LukeMathWalker 0f5fb47
Cleaned comments and debugging prints.
LukeMathWalker 177e03b
Fixed index overflow bug.
LukeMathWalker 811e84f
Fixed issues with index overflow.
LukeMathWalker b618377
Remove useless type annotation.
LukeMathWalker 8994eae
Refactored randomized_partition and partition to properly use
LukeMathWalker 9359134
Restored previous version of randomized_select.
LukeMathWalker 43d765e
Modified all function signatures to accept mutable views instead of
LukeMathWalker 0dec699
Added macro_use to get azip! in numerics.
LukeMathWalker 9315413
Added macro_use to macrozip to get azip! in numeric.
LukeMathWalker 212d1b7
Added an implementation of percentile_axis that requires a mutable
LukeMathWalker ccc8b04
We need to increment the index by 1 to get the correct result
LukeMathWalker 54f227a
Mapping passes i instead of i+1 to randomized_select, but we use ceil to
LukeMathWalker 461e258
Added some documentation for percentile_axis_mut.
LukeMathWalker 184d65d
Added an assert to prevent invalid q values.
LukeMathWalker e290bff
Changed end of recursion condition - it needs to check for n==1 not n…
LukeMathWalker 911a656
Added a new test for the maximum, as well as testing it on arr1.
LukeMathWalker c57fb25
Split test into two more meaningful tests.
LukeMathWalker 2107f56
Added more documentation
LukeMathWalker 07bc655
Updated to version 0.5.0 of rand.
LukeMathWalker 891fe95
Updated to use the proper way of generating random integers.
LukeMathWalker 540c495
Updated docs.
LukeMathWalker e22f889
Updated docs.
LukeMathWalker 54b1878
Changing tests for randomized_select - we want to get i to be the index
LukeMathWalker a54b696
Renamed randomized_select: now nth_mut. Modified all functions to mak…
LukeMathWalker 337d389
nth_mut renamed ith_mut, to have coherence with argument naming strat…
LukeMathWalker 14f1605
Improved variable naming.
LukeMathWalker 10603a2
partition renamed partition_mut.
LukeMathWalker cbcf69a
Added documentation to partition. Renamed variable for better
LukeMathWalker 4d71df7
Shortened function signature.
LukeMathWalker 6e06f13
Using more expressive variable names in partition_mut.
LukeMathWalker 31f0f28
Removed unnecessary auxiliary variable, to achieve more meaningful
LukeMathWalker 77629ca
Updated test_partition into test_partition_mut.
LukeMathWalker eee88ce
Updated test_randomized_select into test_ith_mut.
LukeMathWalker 5a29f47
Fixed bug in test_partition_mut.
LukeMathWalker 310b53e
Fixed comparison to make documentation aligned to actual function
LukeMathWalker 6351601
Fixed edge case
LukeMathWalker 5defbcc
Moved tests to test module.
LukeMathWalker a3122e9
Fixed erroneous complexity indication. Added link to algorithm implem…
LukeMathWalker 243f12c
Added link to algorithm description
LukeMathWalker 2933b28
Merged
LukeMathWalker 71ad410
Fixed unclosed braces.
LukeMathWalker 517621c
Properly reorganized functions to be used as method whenever possible
LukeMathWalker 08ccac9
Updated function calls in tests.
LukeMathWalker f9ed81e
Improved test formatting
LukeMathWalker fd11be0
Fixed doc typo.
LukeMathWalker e4325a1
Removed unnecessary referencing for cloning.
LukeMathWalker 35dd35b
Removed unnecessary call to view_mut.
LukeMathWalker 7475610
Added Hoare routine, with docs and proper reworking of ith_mut
LukeMathWalker 5240811
Added some tests for hoare_partition_mut
LukeMathWalker ca2f3f9
Improved docs and tests
LukeMathWalker ddc0c65
Merge remote-tracking branch 'upstream/master' into order-statistics
LukeMathWalker 3999031
Using map_axis_mut to simplify percentile_axis_mut
LukeMathWalker ee4eb05
Remove patch number specification for rand.
LukeMathWalker 4be2146
Refactored ith_mut. Removed random_pivot.
LukeMathWalker 37e90a9
Refactored partition_hoare_mut.
LukeMathWalker 5145b8c
Renamed hoare_partition_mut to partition_mut.
LukeMathWalker 630106b
Reworked docs.
LukeMathWalker d3cc1ac
Modified signature. Simplified index calculation
LukeMathWalker a6fecc7
Inlined closure.
LukeMathWalker 90774bc
Modified docs to include NaN cases.
LukeMathWalker 3a7f314
Fixing visibility typo.
LukeMathWalker 22415cd
Fixed edge case
LukeMathWalker b1ce4cc
Merged tests. Changed test assertions
LukeMathWalker fcc9f82
Added test for edge case
LukeMathWalker 7e1b503
Renamed ith_mut to sorted_get_mut
LukeMathWalker 393b6bb
Added different interpolation strategies for the percentile index.
LukeMathWalker a9f148d
Renamed Highest to Higher, for coherence. Fixed docs, added docs to I…
LukeMathWalker 0bd4c71
Fixed visibility of InterpolationStrategy
LukeMathWalker ded4e94
Updated tests to add new argument to percentile_axis_mut
LukeMathWalker c6c459d
Merge branch 'master' of https://github.com/bluss/ndarray into order-…
LukeMathWalker 1ec4e42
Implementing interpolation strategies as trait bounds.
LukeMathWalker 63bbb07
Providing some default methods.
LukeMathWalker 3d1a196
Mysterious type annotation error.
LukeMathWalker 10a72d0
Fixed.
LukeMathWalker f8b7713
Making Lower, Upper, Nearest public.
LukeMathWalker e7d1f61
Removed empty line.
LukeMathWalker cec96ca
Re-exporting functions, structs and traits.
LukeMathWalker c786eac
Fixed import.
LukeMathWalker 744a427
Fixed test cases.
LukeMathWalker bdc8c3a
Updated docs.
LukeMathWalker b526445
Fixed docs.
LukeMathWalker 1b39c61
Fixed warnings on unused variables.
LukeMathWalker 00ddf37
Merge pull request #1 from LukeMathWalker/interpolation-strategy
LukeMathWalker e90555e
Implemented Midpoint. Refactored code to change types of variables.
LukeMathWalker 1d094e8
Defined Linear.
LukeMathWalker f5f77ea
Added Interpolate implementation for Linear.
LukeMathWalker ff51479
Fixed docs!
LukeMathWalker 15aa626
Merge pull request #2 from LukeMathWalker/add-more-interpolation-stra…
LukeMathWalker d4e7de7
Removed unused constraint on A.
LukeMathWalker caf58ee
Reducing the scope of search for upper_index element if lower_index was
LukeMathWalker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
pub use self::impl_numeric::*; | ||
|
||
mod impl_numeric; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, put an empty line after the short description on the first line of doc comments. It doesn't really make a significant difference for instance methods like this, but it does affect the docs of implementors of trait methods, and it's nice to be consistent. See here for an example of the effect of an empty line. Note the "Read more" text.