Skip to content

Add documentation for slicing with negative step #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

jturner314
Copy link
Member

See also #312.

@bluss
Copy link
Member

bluss commented Feb 26, 2018

Thanks!

@bluss bluss merged commit 70effa7 into rust-ndarray:master Feb 26, 2018
@bluss
Copy link
Member

bluss commented Feb 26, 2018

@jturner314 Do you want to be a co-maintainter of this crate?

@jturner314 jturner314 deleted the neg-step-slice-docs branch February 27, 2018 05:30
@jturner314
Copy link
Member Author

jturner314 commented Feb 27, 2018

@bluss What exactly do you have in mind? I'm happy to help answer issues and review PRs. Would I have write access? I'm comfortable with improving documentation and making bug fixes by myself, but I'm a little hesitant to make/merge public API changes without having someone else take a second look (at least before a new version is released).

@bluss
Copy link
Member

bluss commented Feb 27, 2018

Sure, write access and coownership of the ndarray crates.

@jturner314
Copy link
Member Author

Okay, I accept.

Thanks again for creating ndarray! I've recently finished a >10 kloc project that uses ndarray extensively, and ndarray has worked really well.

@bluss
Copy link
Member

bluss commented Feb 27, 2018

🌟 Yay! That means we have doubled the number of maintainers of ndarray, thanks to @jturner314 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants