-
Notifications
You must be signed in to change notification settings - Fork 321
The great dimension migration to Dim<[Ix; N]>
#225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dramatically increases usability of dynamic-dimension arrays by allowing indexing like a[[i, j]] for them.
3c18c2c
to
8a0cf80
Compare
8a0cf80
to
9832287
Compare
@SuperFluffy Serialization changes, now serializes dimensions as arrays instead of tuples. I think the defacto format for json remains the same in both serialization libs, |
f5bd373
to
6afabb0
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you thought I was slacking, finally the rework of ndarray's dimension handling is ready (almost).
To have your code be compatible with ndarray 0.6.8 and with this and the future: Use the dimension type aliases. Use
Array<X, Ix1>
orArray1
for 1d arrays,Array<X, Ix2>
orArray2
for 2d arrays and so on. Then transition will be very smooth.Array::zeros((3, 4))
).Dim
struct.Dim<[usize; 2]>
is a 2D dimension.Requires Rust 1.12 (macro expansion of tt).
Fixes #6