-
Notifications
You must be signed in to change notification settings - Fork 323
Add .as_slice_memory_order(), improve scalar_sum, and fix bugs in from_vec_dim_stride #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SuperFluffy the ordering agnostic version of |
e49aace
to
3edea96
Compare
5b36868
to
462829b
Compare
This is a non-breaking change because these traits have no methods (no naming conflicts can occur), and the only legal NdFloat impls are f32 and f64, so no impls can break.
This adds a test that ensures order indices are unique even when strides are equal.
Should be memset but is not in current rust nightly.
bluss
added a commit
that referenced
this pull request
Mar 13, 2016
Add .as_slice_memory_order(), improve scalar_sum, and fix bugs in from_vec_dim_stride
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #138
Fixes #58
Fixes #144
Using cargo-benchcmp to review performance changes
The true improvement here is assign scalar for the transposed (f-order) case and scalar_sum should improve the same way. Most important was though to validate that there are no perf regressions. Everything looks like it's the same or within error.