Skip to content

Switch to blas-sys and use BLAS in .mat_mul #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 11, 2016
Merged

Switch to blas-sys and use BLAS in .mat_mul #134

merged 13 commits into from
Mar 11, 2016

Conversation

bluss
Copy link
Member

@bluss bluss commented Mar 9, 2016

Use transparent BLAS support in .mat_mul().

  • Switch to using blas-sys and raw cblas function calls. The savings on overhead are noticeable compared to rblas's trait object interface.
  • blas-sys allows selecting which library provides blas.
  • You must now use feature flag blas to use BLAS in .dot() and .mat_mul()
  • This half-deprecates the feature flag rblas. If the rblas API is attractive, it can move to a separate crate.

@bluss
Copy link
Member Author

bluss commented Mar 11, 2016

needs to be consistent in memory order of the returned array (blas vs no blas).

☑️

@bluss bluss force-pushed the blas-matmul branch 3 times, most recently from 86fc035 to bcd0451 Compare March 11, 2016 15:56
@bluss bluss changed the title Use BLAS in .mat_mul Switch to blas-sys and use BLAS in .mat_mul Mar 11, 2016
bluss added a commit that referenced this pull request Mar 11, 2016
Switch to blas-sys and use BLAS in .mat_mul
@bluss bluss merged commit eb41afa into master Mar 11, 2016
@bluss bluss deleted the blas-matmul branch March 11, 2016 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant