Skip to content

0.2.0 release #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 13, 2019
Merged

Conversation

LukeMathWalker
Copy link
Member

Getting ready for releasing - I have added a new entry to the changelog, updated dependencies where needed and put some more info on the README.md.

Are we ready to go? What do you think @jturner314?

Copy link
Member

@jturner314 jturner314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me; I just had one question.

Before we release 0.2, it would be good to merge #37 and #38 because they're breaking changes. (Note that if we merge #38, we should add to the release notes in the README that the extension traits can no longer be implemented in other crates.) I've also created #40, but it can wait until 0.2.1 if needed.

@LukeMathWalker
Copy link
Member Author

I merged all of them - things we already discussed and agreed upon.
I have added a note on extension traits to the changelog, as you suggested.

Copy link
Member

@jturner314 jturner314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rearranged the changelog slightly. Everything looks good to me. I think we're ready to release once this is merged!

Would you like to do the release, or would you like me to handle it?

@LukeMathWalker
Copy link
Member Author

Let me try, let's see if I can get it right 😛

@LukeMathWalker LukeMathWalker merged commit 6722934 into rust-ndarray:master Apr 13, 2019
@LukeMathWalker LukeMathWalker deleted the 0.2.0-release branch April 13, 2019 09:58
@jturner314
Copy link
Member

@LukeMathWalker Thanks for doing the release. Will you please add a 0.2.0 tag to the commit in Git and push the tag to GitHub?

@LukeMathWalker
Copy link
Member Author

Done! (although directly from GitHub GUI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants