Skip to content

Deploy French translation #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gitsignore
Copy link
Contributor

@gitsignore gitsignore commented Jun 1, 2020

Enabled French translations.

@rust-lang-owner

@gitsignore gitsignore force-pushed the feat/enable-french-translation branch from b84fb54 to 3682ef1 Compare June 1, 2020 08:11
@Manishearth
Copy link
Member

Has this been approved by the translation team?

@phaazon

@hadronized
Copy link
Contributor

We were left with some questions about two words. Ping @nightmared.

To me, it should be okay to release, as 99,9% of the work is done, reviewed and okay. The remaining words (two) are nit-picking that we can resolve later, as both suggestions are okay.

@nightmared
Copy link
Contributor

I concur with @phaazon, this looks all right to me.

@Manishearth Manishearth merged commit eb75c19 into rust-lang:master Jun 2, 2020
@Manishearth
Copy link
Member

Alright, please check out https://www-staging.rust-lang.org/fr and ensure stuff is working right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants