Skip to content
This repository was archived by the owner on Nov 18, 2022. It is now read-only.

Can't start RLS – detected channel name includes default #522

Closed
danlucraft opened this issue Mar 8, 2019 · 5 comments
Closed

Can't start RLS – detected channel name includes default #522

danlucraft opened this issue Mar 8, 2019 · 5 comments

Comments

@danlucraft
Copy link

It appears that rls-vscode is detecting a channel name like "stable-x86_64-apple-darwin (default)":

[Extension Host] Detected active channel: stable-x86_64-apple-darwin (default) (since 'rust-client.channel' is unspecified)

This is causing the rustup command to fail as the "(default)" part is not actually part of the toolchain name:

Error: Command failed: rustup component list --toolchain stable-x86_64-apple-darwin (default)
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `rustup component list --toolchain stable-x86_64-apple-darwin (default)'

Stripping the "(default)" and setting rust-client.channel to "stable-x86_64-apple-darwin" fixes the issue.

So it seems like the code that detects the channel name needs to be able to recognise and strip "(default)" from wherever it is finding that. I'll take a look and see if I can see where that happens, but I'm not experienced with VSCode extensions, or rustup.

vscode  1.32.1
rustc   1.33.0 (2aa4c46cf 2019-02-28)
rustup  1.17.0 (069c88ed6 2019-03-05)
@danlucraft
Copy link
Author

Aaaaaand closing this because I found the closed issues that discuss it.

@Xanewok Xanewok pinned this issue Mar 8, 2019
@Xanewok
Copy link
Member

Xanewok commented Mar 8, 2019

Pinning it to make it more visible for other folks; this should be fixed with #520.

@softprops
Copy link

Pinning it to make it more visible for other folks

Is there a work around atm?

@angusgraham
Copy link
Contributor

@softprops yes, the solution is in #517:

Add "rust-client.channel": "stable" to your settings.

@angusgraham
Copy link
Contributor

Fixed in 0.5.4

@Xanewok Xanewok unpinned this issue Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants