Remove T-all special case

Author: Kobzol

src/validate.rs

@@ -746,7 +746,7 @@ fn validate_zulip_id_allowlist(data: &Data, errors: &mut Vec<String>) {
     let mut members = data
         .config()
         .members_without_zulip_id()
-        .into_iter()
+        .iter()
         .collect::<Vec<_>>();
     members.sort();
     for member in members {
@@ -780,15 +780,17 @@ fn validate_zulip_group_ids(data: &Data, errors: &mut Vec<String>) {
                         // Okay, have zulip IDs.
                     }
                     ZulipMember::MemberWithoutId { github } => {
-                        // Bad, only github handle, no zulip ID, even though included in zulip user
-                        // group
-                        bail!(
-                            "person `{}` in '{}' is a member of a Zulip user group '{}' but has no \
-                            Zulip id",
-                            github,
-                            team.name(),
-                            group.name()
-                        );
+                        if !data.config().members_without_zulip_id().contains(github) {
+                            // Bad, only github handle, no zulip ID, even though included in zulip user
+                            // group
+                            bail!(
+                                "person `{}` in '{}' is a member of a Zulip user group '{}' but has no \
+                                Zulip id",
+                                github,
+                                team.name(),
+                                group.name()
+                            );
+                        }
                     }
                 }
                 Ok(())
@@ -813,11 +815,13 @@ fn validate_zulip_stream_ids(data: &Data, errors: &mut Vec<String>) {
                 match member {
                     ZulipMember::MemberWithId { .. } | ZulipMember::JustId(_) => {}
                     ZulipMember::MemberWithoutId { github } => {
-                        bail!(
-                            "person `{github}` is a member of a Zulip stream `{}` defined in team `{}`, but has no Zulip id",
-                            stream.name(),
-                            team.name()
-                        );
+                        if !data.config().members_without_zulip_id().contains(github) {
+                            bail!(
+                                "person `{github}` is a member of a Zulip stream `{}` defined in team `{}`, but has no Zulip id",
+                                stream.name(),
+                                team.name()
+                            );
+                        }
                     }
                 }
                 Ok(())

teams/all.toml

@@ -31,26 +31,7 @@ extra-emails = [
 
 [[zulip-groups]]
 name = "T-all"
-# Exclude the following people from the Zulip group for grandfathering purposes,
-# where previously we didn't require all project team members to have Zulip IDs
-# (since there wasn't a `T-all` Zulip group previously).
-excluded-people = [
-    "U007D",
-    "andrewpollack",
-    "bnchi",
-    "celaus",
-    "opeolluwa",
-]
 
 # Private channel with all team members, so that we can have an easy way of reaching them.
 [[zulip-streams]]
 name = "all/private"
-# Exclude the following people from the Zulip stream for grandfathering purposes,
-# where previously we didn't require all project team members to have Zulip IDs.
-excluded-people = [
-    "U007D",
-    "andrewpollack",
-    "bnchi",
-    "celaus",
-    "opeolluwa",
-]