-
Notifications
You must be signed in to change notification settings - Fork 289
Automatic verification of MIPS MSA intrinsics #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks @gnzlbg!
The only general comment I'd have is that we may want to double check for a more official source for intrinsic definitions other than a gcc header file. I know at least on x86 the __builtin_*
functions all don't always map well to Intel's own names (and often don't correspond to intrinsics). I know very little about MIPS SIMD though, so if gcc is more 1:1 with upstream vendors then seems fine by me!
The problem is that the C headers that do not include the |
The clang header does the same: https://clang.llvm.org/doxygen/msa_8h_source.html |
Ah ok that at least means directly using the |
FYI i tried to enable checking the instructions, but something appears to be broken in the code that parses the |
Ah no worries, if you want to land this an open an issue I can follow-up later poking around to see if I can enable this |
I'll wait for @rbirdic to review the proposed changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnzlbg This looks good to me. Thank you!
This PR adds automatic-verification of the MIPS MSA intrinsic type signatures
cc @rbirdic @wzssyqa