deprecate read/write eflags #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
force-pushed
the
deprecate_eflags
branch
2 times, most recently
from
cfe0363 to
2cf8650
Compare
gnzlbg
force-pushed
the
deprecate_eflags
branch
2 times, most recently
from
89dcee9 to
4b7f75f
Compare
|
Which rust version belongs exactly to the deprecation attribute? It might hit nightly in the next weeks, so it should be two stable versions from now (1.29) right? |
|
At a high level this LGTM, but I don't know enough about the particulars of how exactly things are deprecated to feel comfortable signing off on this. cc @rust-lang-nursery/libs @alexcrichton |
|
FWIW these are covered by this block during verification which is why they passed through to stable without actually being defined by Intel. I think it's a compelling enough argument to deprecate these intrinsics currently and we can always undeprecate if we really need to (or if some LLVM "bug" is fixed or something like that) Thanks for the PR @gnzlbg! |
TheIronBorn
pushed a commit
to TheIronBorn/stdsimd
that referenced
this pull request
Jun 29, 2018
TheIronBorn
pushed a commit
to TheIronBorn/stdsimd
that referenced
this pull request
Jun 29, 2018
lu-zero
pushed a commit
to lu-zero/stdarch
that referenced
this pull request
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates
__{read,write}eflags.