Skip to content

Relative links to arch modules #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Relative links to arch modules #487

wants to merge 2 commits into from

Conversation

pravic
Copy link

@pravic pravic commented Jun 22, 2018

Currently stdsimd modules point to the documentation hosted at https://rust-lang-nursery.github.io/stdsimd/aarch64/stdsimd/ instead of https://doc.rust-lang.org/std/arch/ which is confusing.

Since Rust 1.27 has shipped the stdsimd, and its documentation is hosted on the official site, it is essential to make those links relative.

The only exception are links to powerpc and powerpc64, because they are unavailable (yet?).

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 23, 2018

The only exception are links to powerpc and powerpc64, because they are unavailable (yet?).

That should have been fixed in #486

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 23, 2018

I've restarted the travis-ci build, let me know if the powerpc links are still broken.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 23, 2018

The coresimd links need to be updated as well: https://github.com/rust-lang-nursery/stdsimd/blob/master/coresimd/mod.rs#L40

Basically, after this PR there shouldn't be any links to https://rust-lang-nursery.github.io/ (that is, grepping the library for that should return no matches).

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 25, 2018

@pravic any progress on this or is there a blocker? (do you need help / are you stuck with something that we can help with? :) )

@pravic
Copy link
Author

pravic commented Jun 25, 2018

What progress? I've changed a couple of links, that's all from me. Feel free to cherry pick this and put wherever you want.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 26, 2018

Thanks for working on this! I've made some changes and submitted this in #506 which should land soon.

@gnzlbg gnzlbg closed this Jun 26, 2018
@pravic
Copy link
Author

pravic commented Jul 6, 2018

Ok, great. Even though the current nightly does not contain it still, I hope it will soon.

@pravic pravic deleted the patch-1 branch July 6, 2018 12:51
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 6, 2018

@pravic the current nightly was generated on 2018-06-28 :/ Hopefully a new nightly will come up soon.

@pravic
Copy link
Author

pravic commented Jul 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants