tag private modules with doc(cfg) #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix rust-lang/rust#50988, but we'll need to run doctests for libcore on a powerpc64 machine to be sure
This applies
#[doc(cfg(...))]attributes to the internal backing modules so that if doctests are run from these private modules (which they shouldn't, but the linked issue implies that they are...), they still have the propertarget_archfiltering. This will make the docs for these items much more noisy, but i have a plan to patch rustdoc to "reduce" these conditionals, at least for the case being introduced here.