Avx #105
Merged
Avx #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Oct 9, 2017
| /// specified by `imm8`. | ||
| #[inline(always)] | ||
| #[target_feature = "+avx,+sse"] | ||
| #[cfg_attr(test, assert_instr(vcmpeqps, imm8 = 0))] // TODO Validate vcmpps |
There was a problem hiding this comment.
Does this mean that we just need more assert_instr attributes? Or should the intrustruction here be different?
There was a problem hiding this comment.
We need more assert_instr: the instruction depends on the comparison operand.
alexcrichton
reviewed
Oct 9, 2017
src/x86/sse.rs
Outdated
| #[inline(always)] | ||
| #[target_feature = "+sse"] | ||
| pub unsafe fn _mm_undefined_ps() -> f32x4 { | ||
| mem::uninitialized() |
There was a problem hiding this comment.
I think this may be causing a fault on i586?
There was a problem hiding this comment.
Thanks: when I saw #101, I should have fix _mm_undefined_ps but I did not.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.