Skip to content

SO_NOSIGPIPE not set on ios #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dignifiedquire opened this issue Jun 2, 2020 · 3 comments · Fixed by #84
Closed

SO_NOSIGPIPE not set on ios #83

dignifiedquire opened this issue Jun 2, 2020 · 3 comments · Fixed by #84

Comments

@dignifiedquire
Copy link
Contributor

I am experiencing trouble with sigpipes using socket2 on ios. The code already sets nosigpipe by default for macos, is there a reason this is not done for ios as well?

@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented Jun 2, 2020

No reason I think. It would require changing: https://github.com/alexcrichton/socket2-rs/blob/b3badc7d3d599746a3632666876f1a253476c3c7/src/sys/unix.rs#L264 to #[cfg(target_vendor = "apple")]. @dignifiedquire would you like to send a pr?

@dignifiedquire
Copy link
Contributor Author

Done: #84

I went with any(target_os = "macos", target_os = "ios") to match the rest of the cfgs in that file

@Thomasdezeeuw
Copy link
Collaborator

I think for the long term we should move to target_vendor to support tvOS and watchOS (?), but that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants