Skip to content

add actions on process_lines #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2020
Merged

Conversation

zeegomo
Copy link
Contributor

@zeegomo zeegomo commented Apr 10, 2020

Draft of how Actions can be implemented. It uses maybe a little more memory than necessary because it duplicates the input line even if it's not modified but I believe that since the input is a single line and it goes out of scope as soon as it reads another line it's not very important to optimize this and this way it's easier to write/understand

@zeegomo zeegomo force-pushed the actions branch 2 times, most recently from 3cf584b to 8449451 Compare April 14, 2020 17:29
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the main struct. Additionally, I'd love to see better expanded documentation for the struct and methods, and a buildtest to ensure the actions correctly work in a sandboxed build.

@zeegomo zeegomo force-pushed the actions branch 2 times, most recently from c2f1796 to 8480f32 Compare April 23, 2020 13:57
@zeegomo zeegomo marked this pull request as ready for review April 24, 2020 07:17
@pietroalbini pietroalbini merged commit 6b0abb8 into rust-lang:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants