Skip to content

refactor(toolchain/names): replace toolchain_sort() with ToolchainName's Ord instance #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2024
Merged

refactor(toolchain/names): replace toolchain_sort() with ToolchainName's Ord instance #3892

merged 3 commits into from
Jun 19, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jun 18, 2024 •
edited
Loading

Closes #3884.

This new implementation also tries to correct the handling of X.Y, X.Y-beta.W and X.Y.Z-beta.W versions' ordering by abusing semver::Comparator's FromStr implementation.

@rami3l rami3l force-pushed the refactor/toolchain-name-sort branch from f738c39 to e147d73 Compare June 18, 2024 12:34
@rami3l rami3l marked this pull request as draft June 18, 2024 12:41
djc
djc reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@djc djc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I had started in the same direction but was a bit afraid of the time needed to get it right -- but would be awesome if you figure it out.

Left some early feedback.

@rami3l rami3l force-pushed the refactor/toolchain-name-sort branch 4 times, most recently from 171e53a to 3cb64d8 Compare June 19, 2024 03:55
@rami3l rami3l marked this pull request as ready for review June 19, 2024 04:34
@rami3l rami3l requested a review from djc June 19, 2024 04:34
@rami3l rami3l changed the title refactor(toolchain/names): replace toolchain_sort with ToolchainName's Ord instance refactor(toolchain/names): replace toolchain_sort() with ToolchainName's Ord instance Jun 19, 2024
@rami3l rami3l force-pushed the refactor/toolchain-name-sort branch from 3cb64d8 to 6cdf0b0 Compare June 19, 2024 05:36
djc
djc approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rami3l rami3l added this pull request to the merge queue Jun 19, 2024
Merged via the queue into rust-lang:master with commit 8ca641f Jun 19, 2024
26 checks passed
@rami3l rami3l deleted the refactor/toolchain-name-sort branch June 19, 2024 11:13
@rami3l rami3l mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider getting rid of toolchain_sort()
2 participants
@rami3l @djc