-
Notifications
You must be signed in to change notification settings - Fork 952
Build for aarch64-apple-darwin #2521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e861aee
to
cb19c08
Compare
The macos changes need to go in the actions template, otherwise they'll be lost next time we regenerate the actions files. Also I think the set-env stuff needs changing now :D |
Ah, I was waiting for #2515 and it looks like it’s been addressed. |
cb19c08
to
b46366e
Compare
Done.
Done. |
As a final point before I merge this, have you confirmed that |
I think it should do, and I seem to recall you running your cross-built binary on an aarch64 mac, but I just want to be sure |
If I understand you, I think so.
I expect that this PR removes the need to bring in the x86-64 emulator. A future change to the shell script should reduce it to the usual one-liner. |
No description provided.