Rework the PGP key configuration #2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Oct 26, 2019
|
I am deliberately hiding this for now. Once we have proper signature checking integrated, I'll probably add something to the |
This will be used to permit the specification of local PGP public keys which can be used to validate channels and/or rustup releases. Signed-off-by: Daniel Silverstone <[email protected]>
Useful for reading (small) binary files. Signed-off-by: Daniel Silverstone <[email protected]>
We now support reading PGP public keys from environment-specified files and settings specified files. I've chosen to hide pgp_keys from the public part of `Cfg` as a start on data-hiding for better encapsulation. Signed-off-by: Daniel Silverstone <[email protected]>
kinnison
force-pushed
the
kinnison/pgp-keys
branch
from
467e2f2 to
3ed8552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of commits which work toward a better PGP key infrastructure inside Rustup.
In particular it adds (deliberately undocumented at this time) a
settings.tomlentrypgp_keysand the environment variableRUSTUP_PGP_KEY.We add a
PgpKeyenum which indicates where a key came from, so that we can use it in future debugging and/or informational messages to the user.Perhaps @dignifiedquire might take a look over this?