-
Notifications
You must be signed in to change notification settings - Fork 953
Validate pgp signatures #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate pgp signatures #2077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing as a first-cut. We need to have tests which verify that if signatures exist which are bad, we get appropriate warnings, and then we need to think about how we're going to handle the keyring more effectively than the current pair of commented lines; but thank you and I hope my suggestions are useful.
I will need to wait for a more configurable way for keys to put in the real thing unfortunately, as |
☔ The latest upstream changes (presumably #2079) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good now. I'm thinking about how I want to provide key configurability. I will hopefully have an answer for you in the next few days.
63cddaa
to
0ab5596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting to look like it's near to ready.
I think we need to start tidying this into a series of functional commits so that we can get ready to merge. This is looking amazing. |
Uses the pgp crate to validate signatures on downloaded artifacts when they are available and warns if those are not valid. Ref rust-lang#2028
0ab5596
to
597953e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That test looks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, here's hoping it sorts appveyor out :D
Ref #2028