Skip to content

Add some debugging utilities to rustup-mock #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2019
Merged

Add some debugging utilities to rustup-mock #1677

merged 2 commits into from
Mar 4, 2019

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Mar 2, 2019

No description provided.

dwijnand added 2 commits March 2, 2019 10:39
@dwijnand
In rustup-mock's expect_ok_ex dbg stdout & stderr
0990c1e
@dwijnand
In rustup-mock's print_indented, add line counts
1ba104c 
I think this is useful to help understand how two multi-line strings are different.
@dwijnand dwijnand force-pushed the rustup-mock-tweaks branch from 2d1d7f9 to 1ba104c Compare March 2, 2019 11:48
kinnison
kinnison approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that you encountered something which led you to want these extra bits of debug.

I have nothing against them being in.

@dwijnand
Copy link
Member Author

dwijnand commented Mar 3, 2019

Yeah I built these while reviewing #1655, but decided to push them separately rather than tagged on there.

@kinnison
Copy link
Contributor

kinnison commented Mar 4, 2019

Cool, I don't see any danger in including them.

@kinnison kinnison merged commit 297b177 into rust-lang:master Mar 4, 2019
@dwijnand dwijnand deleted the rustup-mock-tweaks branch March 4, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwijnand @kinnison