-
Notifications
You must be signed in to change notification settings - Fork 931
subtree-push nightly-2024-08-17 #6285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subtree-push nightly-2024-08-17 #6285
Conversation
This lets us compare a `Token` with a `TokenKind`. It's used a lot, but can be used even more, avoiding the need for some `.kind` uses.
Running the Diff Check Edit: Diff check failed ❌. Here's the snippet that's causing the issue: Diff in rust-analyzer/crates/parser/test_data/parser/inline/ok/question_for_type_trait_bound.rs:1:
-fn f<T>() where T: ?for<> Sized {}
+fn f<T>()
+where
+ T: ?Sized,
+{
+} I think this is a false positive. The input doesn't parse with the updated toolchain:
|
interesting, on rust playground and locally (including older and more recent versions of rustfmt source) i'm able to reproduce the multiline output so i'd tend to agree. if the input can't get past the ast parsing stage with the latest then it'd be left as-is which would explain the diff |
Thanks for the review! |
Bumping the toolchain version as part of a git subtree push
current toolchain (nightly-2024-06-25):
latest toolchain (nightly-2024-08-17):