Skip to content

subtree-push nightly-2024-08-17 #6285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Aug 17, 2024

Bumping the toolchain version as part of a git subtree push

current toolchain (nightly-2024-06-25):

  • 1.81.0-nightly (6b0f4b5ec 2024-06-24)

latest toolchain (nightly-2024-08-17):

  • 1.82.0-nightly (506052d49 2024-08-16)

@ytmimi
Copy link
Contributor Author

ytmimi commented Aug 17, 2024

Running the Diff Check

Edit: Diff check failed ❌. Here's the snippet that's causing the issue:

Diff in rust-analyzer/crates/parser/test_data/parser/inline/ok/question_for_type_trait_bound.rs:1:
-fn f<T>() where T: ?for<> Sized {}
+fn f<T>()
+where
+    T: ?Sized,
+{
+}

I think this is a false positive. The input doesn't parse with the updated toolchain:

cargo run --bin rustfmt
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/rustfmt`
fn f<T>() where T: ?for<> Sized {}
error: `for<...>` binder should be placed before trait bound modifiers
 --> <stdin>:1:24
  |
1 | fn f<T>() where T: ?for<> Sized {}
  |                    -   ^^
  |                    |
  |                    place the `for<...>` binder before any modifiers


@calebcartwright
Copy link
Member

interesting, on rust playground and locally (including older and more recent versions of rustfmt source) i'm able to reproduce the multiline output so i'd tend to agree.

if the input can't get past the ast parsing stage with the latest then it'd be left as-is which would explain the diff

@ytmimi
Copy link
Contributor Author

ytmimi commented Aug 19, 2024

Thanks for the review!

@ytmimi ytmimi merged commit 4489061 into rust-lang:master Aug 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants