Skip to content

Add tests for issue 2534 #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Jul 19, 2022

Closes #2534

The behavior described in the original issue can no longer be reproduced. The tests show that to be the case regardless of if format_macro_matchers is true or false.

Closes 2534

The behavior described in the original issue can no longer be
reproduced. The tests show that to be the case regardless of if
`format_macro_matchers` is `true` or `false`.
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it's fair to close the linked issue. If there's still discussions to be had about desired/target formatting for macros that's really more of a conversation for the style guide and team

@calebcartwright calebcartwright merged commit f2c31ba into rust-lang:master Jul 19, 2022
@ytmimi ytmimi deleted the issue_2534 branch August 7, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces before colons in macro_rules?
2 participants