Adding #4303 to stable #5180
Closed
Adding #4303 to stable #5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from ayazhafiz, branch i/2868. That commit was originally
implemented on the 2.0 branch, while this commit adds it to stable.
Original commit message:
> Adds the option for
>
> - Functions
> - Control flow blocks
> - Expression statements (i.e. `let x = { ... };`)
> - Traits
> - Trait Impls
> - Mods
> - Foreign Mods
>
> If I am missing a kind of item, let me know :)
>
> Closes rust-lang#2868
Cherry-picked from ayazhafiz, branch i/2868. That commit was originally implemented on the 2.0 branch, while this commit adds it to stable.
Cherry-picked from ayazhafiz, branch i/2868. That commit was originally implemented on the 2.0 branch, while this commit adds it to stable.
Cherry-picked from ayazhafiz, branch i/2868. That commit was originally implemented on the 2.0 branch, while this commit adds it to stable.
|
Yikes, I definitely need to do more with this. I'll convert it to a draft for now |
|
Thanks, though I'm going to close this to reduce notification noise |
|
@murchu27 if you want some help bringing this back, feel free to email me (it’s in my bio). I haven’t worked on this project in a while but roughly remember getting around it and how this was done, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ayazhafiz originally created #4303 for v2.0, and it never reached stable (see #5173). This PR cherry-picks the commits from #4303, with a few merge conflicts in
src/items.rsresolved.I only had time to do the cherry-pick, I haven't tested this yet. I'm not sure if anything has changed in the codebase since #4303 that would cause this to no longer work.
I'll get around to testing it soon, just wanted to open the PR now in case someone else got time before me!