-
Notifications
You must be signed in to change notification settings - Fork 926
update chain handling of long lines and block-like parents #3884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f0c94d0
feat: support wrapping call chains with long elements
calebcartwright 40d1544
fix: indenting chain elements with long parent
calebcartwright 617e22a
feat: support configurable chain indent with block-like parent
calebcartwright 25ac66b
fix: chain wrapping with long child item
calebcartwright 79452d5
tests: add more tests for long chain elements
calebcartwright 0a8b110
tests: more visual indent style tests
calebcartwright 065dbaf
refactor: support tuple lit chain parent indent
calebcartwright c850ac7
tests: add more tests for long chain elements
calebcartwright e9acbb5
refactor: more control over chain item indents
calebcartwright d4cae1f
refactor: add chain child indent options
calebcartwright 8089198
tests: more tests for block-like parents
calebcartwright 70f6d1e
refactor: bit of cleanup on chain formatting
calebcartwright 5a84221
tests: add more chains tests
calebcartwright File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always have such a hard time coming up with config names 😄 If this approach seems viable for handling the scenario in #3157 (and it should indeed be configurable) then this should probably be renamed to something more succinct