Skip to content

fix handling on associated type bounds #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

calebcartwright
Copy link
Member

@calebcartwright calebcartwright commented Jun 28, 2019

Fixes #3657 and fixes #3660

@calebcartwright
Copy link
Member Author

I still need to add tests, but not entirely sure where they should go

@topecongiro
Copy link
Contributor

Thank you for the PR!

Assuming that's the correct/expected behavior, where should I add tests for that? Should they go under an issue-3657 directory under ./tests/source/ and ./tests/target/?

You could add tests to existing files (e.g., source/type.rs and target/type.rs) or create new ones (e.g., source/associated_type_bounds.rs and target/associated_type_bounds.rs). We do not have a strict naming convention. They could be any name as long as the suffix of their file path matches.

@calebcartwright
Copy link
Member Author

Tests added, thanks @scampi and @topecongiro!

Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scampi scampi merged commit b6f7f24 into rust-lang:master Jun 29, 2019
@calebcartwright calebcartwright deleted the associated-type-bounds branch June 29, 2019 20:33
@topecongiro topecongiro added this to the 1.3.1 milestone Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustfmt mangles macro input, replacing ':' with '=' Breaks associated_type_bounds
3 participants