Fix is_subpath #3628
Merged
Fix is_subpath #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkuu
reviewed
Jun 14, 2019
|
thanks! |
|
Thank you! And glad I was able to be of some assistance 👍 I was also thinking it would be good to augment the existing tests to catch this "no system/idempotence tests ran" scenario to prevent a future recurrence. The existing test cases include a check to ensure there were 0 failed tests, so perhaps something as simple as adding another check that ensures some minimum number of tests ran/passed could address that. Do folks think that would be valuable/helpful? If so I'd be happy to submit a PR |
|
@calebcartwright that'd be nice to have, to catch such things in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3627.