rewrite_comment: fix block fallback when failing to rewrite an itemized block #3225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nrc @topecongiro is there a change needed for this PR ? |
topecongiro
reviewed
Dec 25, 2018
There was a problem hiding this comment.
My apologies for the late review. I left an comment on minor refactoring. Would you add test for #3224 please?
|
thanks for the review @topecongiro I forgot to commit the test case... |
|
@topecongiro is it possible to re-run the tests ? They failed with |
|
I restarted, but you might need to rebase to get the fix in order to pass CI |
|
This seems good to go as CI is happy now ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3224